[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808345#comment-13808345
 ] 

Hadoop QA commented on BOOKKEEPER-698:
--------------------------------------

Testing JIRA BOOKKEEPER-698


Patch 
[0002-BOOKKEEPER-698.patch|https://issues.apache.org/jira/secure/attachment/12610885/0002-BOOKKEEPER-698.patch]
 downloaded at Tue Oct 29 18:57:25 UTC 2013

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
120
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs 
warnings
{color:green}+1 TESTS{color}
.    Tests run: 882
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/519/

> Bookie client closure is not considering timeoutExecutor
> --------------------------------------------------------
>
>                 Key: BOOKKEEPER-698
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-698
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-698.patch, 0002-BOOKKEEPER-698.patch
>
>
> 'timeoutExecutor' is leaking for every bookie client, it should be closed 
> during bookie client closure. I've seen in tests, scheduler is running and 
> periodically executing the TimeoutTask even after bk client closure.
> Also, timeoutExecutor is missing thread name. IMHO, no need to raise another 
> issue, just including the small change with this JIRA.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to