[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811263#comment-13811263
 ] 

Flavio Junqueira commented on ZOOKEEPER-1805:
---------------------------------------------

Thanks, guys.

bq. Only a very mild suggestion, if you wish you could remove the changes 
introduced by ZOOKEEPER-1732 in Leader.java, Learner.java and QuorumPeer.java.

I don't understand this comment. The change here simply detects that there is a 
mix of messages with and without don't care values, which must correspond to a 
rolling upgrade, so it ignores the corresponding fields and simply verifies 
that the epoch is greater. If this is right, then the changes of ZOOKEEPER-1732 
are still required when everyone is sending don't care values. Am I missing 
anything? 

> "Don't care" value in ZooKeeper election breaks rolling upgrades
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1805
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1805
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Blocker
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1805-b3.4.patch, ZOOKEEPER-1805.patch, 
> ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, 
> ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch
>
>
> This is an issue that has been originally reported in ZOOKEEPER-1732.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to