----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30222 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java <https://reviews.apache.org/r/15753/#comment57829> This line is commented, should the change be removed? ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/15753/#comment57830> Please remove spaces in this line. ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/15753/#comment57831> Please remove spaces. ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/15753/#comment57832> This comment is empty, I guess it should be removed. ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/15753/#comment57833> Please change tab to spaces, and also remove trailing spaces (marked with red color). In general review indentation (spaces instead of tabs), remove trailing spaces. Also, there is no test case included. If the test was in a new file, check that you have done "svn add" before generating the patch. - German Blanco On Dec. 11, 2013, 8:36 a.m., Daniel Peon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15753/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 8:36 a.m.) > > > Review request for zookeeper, German Blanco and fpj. > > > Bugs: ZOOKEEPER-1814 > https://issues.apache.org/jira/browse/ZOOKEEPER-1814 > > > Repository: zookeeper > > > Description > ------- > > See Zookeeper-1814. > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1541529 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1541529 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1541529 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 1541529 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1541529 > > Diff: https://reviews.apache.org/r/15753/diff/ > > > Testing > ------- > > New test case checking that the parameter maxNotificationInterval can be > configurable. > > The test case overwrites the receiveConnection method in QuorumCnxManager > class in order to avoid any answer to Fast Leader Election. Thus, FLE is > forced to retry increasing exponentially the notifications interval. This > interval is measured and the test case stops when 3 consecutive measures are > equal. The test case will be OK if the measure is the configured in the cfg > file. > > > File Attachments > ---------------- > > ZOOKEEPER-1814.patch > > https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch > > > Thanks, > > Daniel Peon > >
