> On Dec. 11, 2013, 8:06 p.m., German Blanco wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 387 > > <https://reviews.apache.org/r/15753/diff/1/?file=389468#file389468line387> > > > > Please remove spaces in this line.
I do not understand because I didn't modify the file QuorumPeer.java. Actually there is no modification information on the patch that I uploaded. Is it something that I'm missing or missunderstanding? On Dec. 11, 2013, 8:06 p.m., Daniel Peon wrote: > > In general review indentation (spaces instead of tabs), remove trailing > > spaces. > > Also, there is no test case included. If the test was in a new file, check > > that you have done "svn add" before generating the patch. I think something wrong happened with the patch generation. Although the .patch file does not contain some of the lines that you could find in the diff command, they are changes that I did before in the code. I just generated a new patch from the LATEST version. Additionally I performed the "svn add" operation before generating the patch also. Please review it if you can just and let's see if I did it right. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30222 ----------------------------------------------------------- On Dec. 12, 2013, 8:30 a.m., Daniel Peon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15753/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 8:30 a.m.) > > > Review request for zookeeper, German Blanco and fpj. > > > Bugs: ZOOKEEPER-1814 > https://issues.apache.org/jira/browse/ZOOKEEPER-1814 > > > Repository: zookeeper > > > Description > ------- > > See Zookeeper-1814. > > > Diffs > ----- > > ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 > ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1550368 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1550368 > > ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15753/diff/ > > > Testing > ------- > > New test case checking that the parameter maxNotificationInterval can be > configurable. > > The test case overwrites the receiveConnection method in QuorumCnxManager > class in order to avoid any answer to Fast Leader Election. Thus, FLE is > forced to retry increasing exponentially the notifications interval. This > interval is measured and the test case stops when 3 consecutive measures are > equal. The test case will be OK if the measure is the configured in the cfg > file. > > > File Attachments > ---------------- > > ZOOKEEPER-1814.patch > > https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch > > > Thanks, > > Daniel Peon > >
