[
https://issues.apache.org/jira/browse/ZOOKEEPER-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851566#comment-13851566
]
Flavio Junqueira commented on ZOOKEEPER-1849:
---------------------------------------------
Thanks, Germán. Would you mind posting this on the review board so that it is
easier to check the position of the shutdown calls? It looks good from a high
level, but I'd like to have a closer look. Also, could you please check the
format of the parts of the code this patch is touching, in particular
LoadFromLogTest? The indentation does not seem right.
> NioNettySuiteTest fails in windows build
> ----------------------------------------
>
> Key: ZOOKEEPER-1849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1849
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 3.4.5, 3.5.0
> Reporter: Germán Blanco
> Assignee: Germán Blanco
> Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1849.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)