[
https://issues.apache.org/jira/browse/ZOOKEEPER-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852461#comment-13852461
]
Flavio Junqueira commented on ZOOKEEPER-1849:
---------------------------------------------
Reformatting the whole file is typically a bad idea because the reformat
changes get mixed with the changes of the patch and it becomes to difficult to
understand what is going on. Some people are more strict than I tend to be with
this, and I'm personally ok if you do a small number of reformat changes around
the original changes of the patch. But, someone can always come and say that
this is not a reformatting issue and -1 it.
> NioNettySuiteTest fails in windows build
> ----------------------------------------
>
> Key: ZOOKEEPER-1849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1849
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 3.4.5, 3.5.0
> Reporter: Germán Blanco
> Assignee: Germán Blanco
> Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1849.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
