[
https://issues.apache.org/jira/browse/ZOOKEEPER-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856818#comment-13856818
]
Rakesh R commented on ZOOKEEPER-1852:
-------------------------------------
I've uploaded patch, where I've splitted the creation and starting of the
serverinstance. With this, teardown flow will be able to shutdown the created
serverCnxnFactory. Please review the changes.
> ServerCnxnFactory instance is not properly cleanedup
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1852
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1852
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1852-br-3.4.patch
>
>
> ClientBase#createNewServerInstance() - Say the startup of the server fails,
> this will not initialize 'serverFactory' and will be null. When the flow
> comes to teardown/shutdown, it will bypass stopping of this server instance
> due to the following check. This will affect other test case verifications
> like, jmx check 'JMXEnv#ensureOnly'.
> ClientBase#shutdownServerInstance
> {code}
> static void shutdownServerInstance(ServerCnxnFactory factory,
> String hostPort)
> {
> if (factory != null) {
> //...shutdown logic
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
