[
https://issues.apache.org/jira/browse/ZOOKEEPER-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857319#comment-13857319
]
Hadoop QA commented on ZOOKEEPER-1852:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12620583/ZOOKEEPER-1852.patch
against trunk revision 1552946.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1865//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1865//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1865//console
This message is automatically generated.
> ServerCnxnFactory instance is not properly cleanedup
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1852
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1852
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1852-br-3.4.patch,
> ZOOKEEPER-1852-br-3.4.patch, ZOOKEEPER-1852.patch, ZOOKEEPER-1852.patch
>
>
> ClientBase#createNewServerInstance() - Say the startup of the server fails,
> this will not initialize 'serverFactory' and will be null. When the flow
> comes to teardown/shutdown, it will bypass stopping of this server instance
> due to the following check. This will affect other test case verifications
> like, jmx check 'JMXEnv#ensureOnly'.
> ClientBase#shutdownServerInstance
> {code}
> static void shutdownServerInstance(ServerCnxnFactory factory,
> String hostPort)
> {
> if (factory != null) {
> //...shutdown logic
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
