[
https://issues.apache.org/jira/browse/ZOOKEEPER-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859423#comment-13859423
]
Flavio Junqueira commented on ZOOKEEPER-1852:
---------------------------------------------
It looks good for me too. The minor request I have is that we document in the
code the reason for splitting the creation and the start of the server. By
documenting in the code, I mean some short comment and a pointer to the jira
issue. Would you mind doing it, [~rakeshr]?
> ServerCnxnFactory instance is not properly cleanedup
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1852
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1852
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1852-br-3.4.patch,
> ZOOKEEPER-1852-br-3.4.patch, ZOOKEEPER-1852.patch, ZOOKEEPER-1852.patch
>
>
> ClientBase#createNewServerInstance() - Say the startup of the server fails,
> this will not initialize 'serverFactory' and will be null. When the flow
> comes to teardown/shutdown, it will bypass stopping of this server instance
> due to the following check. This will affect other test case verifications
> like, jmx check 'JMXEnv#ensureOnly'.
> ClientBase#shutdownServerInstance
> {code}
> static void shutdownServerInstance(ServerCnxnFactory factory,
> String hostPort)
> {
> if (factory != null) {
> //...shutdown logic
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
