----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19522/#review38330 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/19522/#comment70376> nit: drop the ()s, doesn't add value since it isn't a compound expression. ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/19522/#comment70377> i think you want this.minSessionTimeout not min. ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/19522/#comment70378> same comments as for setMinSessionTimeout. ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19522/#comment70386> why not PortAssignment.unique()? ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19522/#comment70385> why not PortAssignment.unique()? ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19522/#comment70384> why do we need to create/get anything? sounds like asserting you that the negotiated timeout is what was expected should be enough no? - Raul Gutierrez Segales On March 21, 2014, 7:58 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19522/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 7:58 a.m.) > > > Review request for zookeeper, fpj, michim, Patrick Hunt, and Raul Gutierrez > Segales. > > > Bugs: ZOOKEEPER-1263 > https://issues.apache.org/jira/browse/ZOOKEEPER-1263 > > > Repository: zookeeper > > > Description > ------- > > Fix handling of min/max session timeout value initialization. Addresses > foollowing cases:- > 1) Server startup fails if configured only with the 'minSessionTimeout' and > not 'maxSessionTimeout' > 2) Log is showing -1 as min/max session timeout if there is no sessiontimeout > value configured > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1579879 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1579879 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1579879 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java > 1579879 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java > 1579879 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1579879 > > Diff: https://reviews.apache.org/r/19522/diff/ > > > Testing > ------- > > Tests covering standalone & quorum cases. > > > Thanks, > > Rakesh R > >
