-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19522/
-----------------------------------------------------------
(Updated March 25, 2014, 6:01 p.m.)
Review request for zookeeper, fpj, michim, Patrick Hunt, and Raul Gutierrez
Segales.
Changes
-------
Thanks Michi, Raul for the reviews and your time. I'm uploading the latest
patch.
I've done the changes except the duplicate condition present in ZKServer, for
that pls see my reply.
Bugs: ZOOKEEPER-1263
https://issues.apache.org/jira/browse/ZOOKEEPER-1263
Repository: zookeeper
Description
-------
Fix handling of min/max session timeout value initialization. Addresses
foollowing cases:-
1) Server startup fails if configured only with the 'minSessionTimeout' and not
'maxSessionTimeout'
2) Log is showing -1 as min/max session timeout if there is no sessiontimeout
value configured
Diffs (updated)
-----
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1581425
./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1581425
./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
1581425
./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
1581425
./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
1581425
./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
1581425
Diff: https://reviews.apache.org/r/19522/diff/
Testing
-------
Tests covering standalone & quorum cases.
Thanks,
Rakesh R
