[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970448#comment-13970448
 ] 

Alexander Shraer commented on ZOOKEEPER-1824:
---------------------------------------------

Hi [~abutala],

I'm not familiar with MiniZooKeeperCluster, can you explain the benefit of 
having it in addition to / instead of the current options ? Perhaps you could 
instead enhance one of the existing classes if something is missing ? There are 
already at least 2 options for creating an ensemble in tests, do we need a 
third one ?

BTW, one thing that was missing for me in QuorumUtil is the fact that its its 
"restart" method just creates a new server instead of starting the old one I 
stopped. For this reason I sometimes use QuorumPeerTestBase. So for example 
ReconfigTest.java uses QuorumUtil and ReconfigRecoveryTest.java uses 
QuorumPeerTestBase.

Alex

> We need a MiniZooKeeperCluster for unit test
> --------------------------------------------
>
>                 Key: ZOOKEEPER-1824
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1824
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: tests
>            Reporter: chendihao
>
> We are developing a timestamp server to offer a precise auto increasing 
> timestamp for other processes. ZooKeeper is used to select the master and 
> store the persistent max offered timestamp. 
> Now I'm not sure if the zookeeper servers work well no matter how much I 
> damage the cluster randomly. So we need unit tests but ZooKeeper doesn't 
> provides a single-process  cluster for us. Should we implement the similar 
> code like what HBase did in MiniZooKeeperCluster.java ?
> ref https://issues.apache.org/jira/browse/HBASE-2218



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to