----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20448/#review41037 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/20448/#comment74390> need to remove the part of this that says "or null to remove all watchers" - Camille Fournier On April 17, 2014, 12:45 p.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20448/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 12:45 p.m.) > > > Review request for zookeeper, michim and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-1910 > https://issues.apache.org/jira/browse/ZOOKEEPER-1910 > > > Repository: zookeeper > > > Description > ------- > > RemoveWatches wrongly removes the watcher if multiple watches exists on a > path. As per the comments, we have splitted the removeWatches api into: > - removeWatches(path, watcher, watcherType, local); > - removeAllWatches(path, watcherType, local); > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/ZooKeeper.java 1588229 > ./src/java/main/org/apache/zookeeper/cli/RemoveWatchesCommand.java 1588229 > ./src/java/main/org/apache/zookeeper/server/DataTree.java 1588229 > ./src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 1588229 > ./src/java/main/org/apache/zookeeper/server/WatchManager.java 1588229 > ./src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1588229 > ./src/java/test/org/apache/zookeeper/RemoveWatchesTest.java 1588229 > ./src/zookeeper.jute 1588229 > > Diff: https://reviews.apache.org/r/20448/diff/ > > > Testing > ------- > > included tests > > > Thanks, > > Rakesh R > >
