-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20448/
-----------------------------------------------------------

(Updated April 24, 2014, 6:07 p.m.)


Review request for zookeeper, michim and Raul Gutierrez Segales.


Changes
-------

Updated new patch addressing the comments. Thanks everyone for your time and 
reviews


Bugs: ZOOKEEPER-1910
    https://issues.apache.org/jira/browse/ZOOKEEPER-1910


Repository: zookeeper


Description
-------

RemoveWatches wrongly removes the watcher if multiple watches exists on a path. 
As per the comments, we have splitted the removeWatches api into:
- removeWatches(path, watcher, watcherType, local);
- removeAllWatches(path, watcherType, local);


Diffs (updated)
-----

  ./src/java/main/org/apache/zookeeper/ZooDefs.java 1589795 
  ./src/java/main/org/apache/zookeeper/ZooKeeper.java 1589795 
  ./src/java/main/org/apache/zookeeper/cli/RemoveWatchesCommand.java 1589795 
  ./src/java/main/org/apache/zookeeper/server/DataTree.java 1589795 
  ./src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
1589795 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1589795 
  ./src/java/main/org/apache/zookeeper/server/Request.java 1589795 
  ./src/java/main/org/apache/zookeeper/server/WatchManager.java 1589795 
  ./src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1589795 
  ./src/java/test/org/apache/zookeeper/RemoveWatchesTest.java 1589795 
  ./src/zookeeper.jute 1589795 

Diff: https://reviews.apache.org/r/20448/diff/


Testing
-------

included tests


Thanks,

Rakesh R

Reply via email to