[
https://issues.apache.org/jira/browse/ZOOKEEPER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000875#comment-14000875
]
Alexander Shraer commented on ZOOKEEPER-1659:
---------------------------------------------
One more small comment - in the beginning of updateMXBeans, I suggest to
simplify by having just 2 sets - joiningMembers and leavingMembers.
Set<Long> joiningMembers = new
HashSet<Long>(allMembers.keySet()).removeAll(remotePeerBeans.keySet());
Set<Long> leavingMembers = new
HashSet<Long>(remotePeerBeans.keySet()).removeAll(allMembers.keySet());
note sure about removing getId() from these - see my previous comment.
maybe it'll be also good to rename the parameter allMembers to newMembers.
> Add JMX support for dynamic reconfiguration
> -------------------------------------------
>
> Key: ZOOKEEPER-1659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1659
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Rakesh R
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1659.patch
>
>
> We need to update JMX during reconfigurations. Currently, reconfiguration
> changes are not reflected in JConsole.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
