[
https://issues.apache.org/jira/browse/ZOOKEEPER-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067773#comment-14067773
]
Patrick Hunt commented on ZOOKEEPER-1976:
-----------------------------------------
Here's an example of the issues:
{noformat}
Dm Found reliance on default encoding in
org.apache.jute.compiler.CGenerator.genCode(): new java.io.FileWriter(File)
Dm Found reliance on default encoding in
org.apache.jute.compiler.CppGenerator.genCode(): new java.io.FileWriter(File)
Dm Found reliance on default encoding in
org.apache.jute.compiler.JRecord.genCsharpCode(File): new
java.io.FileWriter(File)
Dm Found reliance on default encoding in
org.apache.jute.compiler.JRecord.genJavaCode(File): new java.io.FileWriter(File)
Dm Found reliance on default encoding in new
org.apache.jute.XmlOutputArchive(OutputStream): new
java.io.PrintStream(OutputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.AddAuthCommand.exec(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.CreateCommand.exec(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.DelQuotaCommand.delQuota(ZooKeeper, String, boolean,
boolean): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.DelQuotaCommand.delQuota(ZooKeeper, String, boolean,
boolean): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.GetCommand.exec(): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.GetCommand.exec(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.GetConfigCommand.exec(): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.GetConfigCommand.exec(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.ListQuotaCommand.exec(): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.ReconfigCommand.exec(): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.SetCommand.exec(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.SetQuotaCommand.createQuota(ZooKeeper, String, long,
int): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.cli.SetQuotaCommand.createQuota(ZooKeeper, String, long,
int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int,
String): new java.io.InputStreamReader(InputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int,
String): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): new
java.io.InputStreamReader(InputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): String.getBytes()
Dm Found reliance on default encoding in new
org.apache.zookeeper.common.AtomicFileWritingIdiom(File,
AtomicFileWritingIdiom$OutputStreamStatement,
AtomicFileWritingIdiom$WriterStatement): new
java.io.OutputStreamWriter(OutputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.server.auth.DigestAuthenticationProvider.generateDigest(String):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.auth.DigestAuthenticationProvider.handleAuthentication(ServerCnxn,
byte[]): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.DataTree.updateBytes(String, long): new
String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.DataTree.updateBytes(String, long):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.DataTree.updateCount(String, int): new
String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.DataTree.updateCount(String, int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.DataTree.updateQuotaForPath(String):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(Request):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.NettyServerCnxn$SendBufferWriter.checkFlush(boolean):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(boolean):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.persistence.FileSnap.<static initializer for
FileSnap>(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.persistence.FileTxnLog.<static initializer for
FileTxnLog>(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(int, long,
Request, Record, boolean): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.FastLeaderElection.sendNotifications():
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.FastLeaderElection$Messenger$WorkerReceiver.run():
new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.FastLeaderElection$Messenger$WorkerReceiver.run():
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.Follower.processPacket(QuorumPacket): new
String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.Learner.syncWithLeader(long): new
String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.LearnerHandler.run(): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.Observer.processPacket(QuorumPacket): new
String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumCnxManager.initiateConnection(Socket,
Long): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumCnxManager.receiveConnection(Socket):
new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumPeer.readLongFromFile(String): new
java.io.FileReader(File)
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumPeerConfig.checkValidity(): new
java.io.FileReader(File)
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumPeerConfig$1.write(OutputStream):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumZooKeeperServer.dumpConf(PrintWriter):
new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.quorum.QuorumZooKeeperServer.dumpConf(PrintWriter):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.Request.toString(): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.ServerCnxn.<static initializer for ServerCnxn>():
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.server.TraceFormatter.main(String[]): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.server.util.OSMXBean.getMaxFileDescriptorCount(): new
java.io.InputStreamReader(InputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.server.util.OSMXBean.getOpenFileDescriptorCount(): new
java.io.InputStreamReader(InputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.server.ZKDatabase.initConfigInZKDatabase(QuorumVerifier):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.dump(String, int): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.dump(String, int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.getTraceMask(String, int):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.kill(String, int): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.kill(String, int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.ruok(String, int): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.ruok(String, int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.setTraceMask(String, int, String):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.stat(String, int): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ServerAdminClient.stat(String, int): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.Shell.runCommand(): new
java.io.InputStreamReader(InputStream)
Dm Found reliance on default encoding in
org.apache.zookeeper.version.util.VerGen.generateFile(File, VerGen$Version,
int, String): new java.io.FileWriter(File)
Dm Found reliance on default encoding in
org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int):
new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int):
String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean,
boolean): new String(byte[])
Dm Found reliance on default encoding in
org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean,
boolean): String.getBytes()
Dm Found reliance on default encoding in
org.apache.zookeeper.ZooKeeperMain.run(): new
java.io.InputStreamReader(InputStream)
{noformat}
> address internationalization issues identified by findbugs 2.0.3
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-1976
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1976
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
>
> Findbugs 2.0.3 found a number of internationalization issues with the code,
> we ignored these for the time being in ZOOKEEPER-1975, however we should
> address them one by one eventually.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
