[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068986#comment-14068986
 ] 

Patrick Hunt commented on ZOOKEEPER-1976:
-----------------------------------------

It's a bit more complicated than that. Take a look at the warnings - e.g. 
FileWriter is being used and it doesn't have the ability to specify the 
encoding. As a result the impact is bigger (granted for simple stuff like 
strings it's not so bad).

Check out this tool used in lucene/solr: 
https://code.google.com/p/forbidden-apis/
also see: https://www.youtube.com/watch?v=PVRdLyQGUxE

See the note on FileReader here: 
http://blog.thetaphi.de/2012/07/default-locales-default-charsets-and.html


> address internationalization issues identified by findbugs 2.0.3
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1976
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1976
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Patrick Hunt
>
> Findbugs 2.0.3 found a number of internationalization issues with the code, 
> we ignored these for the time being in ZOOKEEPER-1975, however we should 
> address them one by one eventually.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to