[
https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082586#comment-14082586
]
Hongchao Deng commented on ZOOKEEPER-1994:
------------------------------------------
{quote}
3. If the version is written in a separate file, it will be difficult to
maintain consistency between the version file and the dynamic configuration
file. Consider updating one of them but not the other and having a failure in
between.
{quote}
I agree that at this moment it doesn't need to be separated out.
h3. Regarding the version appended to file name.
Let me give out two examples:
One is using zxid.
{code}
dynamic.10000001
dynamic.20000004
...
{code}
One is using sequence number
{code}
dynamic.1
dynamic.2
....
{code}
The second looks better. Right?
{quote}
2. Numbering the backups using versions will make backups easy to correlate
across different replicas.
{quote}
Well. I was previously thinking to replace zxid with sequence number as version
across reconfig consistency. So my assumption is that this is gonna be a
relatively big change too.. Just a suggestion.
> Backup config files.
> --------------------
>
> Key: ZOOKEEPER-1994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.0
>
>
> We should create a backup file for a static or dynamic configuration file
> before changing the file.
> Since the static file is changed at most twice (once when removing the
> ensemble definitions, at which point a dynamic file doesn't exist yet, and
> once when removing clientPort information) its probably fine to back up the
> static file independently from the dynamic file.
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a sequence
> number.
> Option 2: have the configuration version be part of the file name for dynamic
> configuration files (instead of in the file like now). Such as
> zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a
> new dynamic file (with new version) and update the link in the static file to
> point to the new dynamic one.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
