[
https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082954#comment-14082954
]
Patrick Hunt commented on ZOOKEEPER-1994:
-----------------------------------------
My 0.02 - I like the idea of using the zxid as the file name suffix. It makes
things easier to debug -- it's very clear which zxid version is associated with
the change. Typically when I'm debugging issues I'm always tying them back to
this value anyway. It also means that we don't need to include the version
number in the file itself - which I also like very much.
> Backup config files.
> --------------------
>
> Key: ZOOKEEPER-1994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.0
>
> Attachments: draft.patch, static-backup.patch
>
>
> We should create a backup file for a static or dynamic configuration file
> before changing the file.
> Since the static file is changed at most twice (once when removing the
> ensemble definitions, at which point a dynamic file doesn't exist yet, and
> once when removing clientPort information) its probably fine to back up the
> static file independently from the dynamic file.
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a sequence
> number.
> Option 2: have the configuration version be part of the file name for dynamic
> configuration files (instead of in the file like now). Such as
> zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a
> new dynamic file (with new version) and update the link in the static file to
> point to the new dynamic one.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
