[
https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083642#comment-14083642
]
Hongchao Deng commented on ZOOKEEPER-1994:
------------------------------------------
[~shralex]
I have finished the functionality. Please take a look.
The next thing would be to
1. fix existing test cases that make assumptions on "zoo.cfg.dynamic"
2. add test case for this patch.
3. refactor "configBackwardCompatibilityMode" variable which isn't useful
anymore and
4. optimize cases where we don't need to edit the static file.
Gonna be another huge patch.
> Backup config files.
> --------------------
>
> Key: ZOOKEEPER-1994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.1
>
> Attachments: draft.patch, first-try.patch, static-backup.patch
>
>
> We should create a backup file for a static or dynamic configuration file
> before changing the file.
> Since the static file is changed at most twice (once when removing the
> ensemble definitions, at which point a dynamic file doesn't exist yet, and
> once when removing clientPort information) its probably fine to back up the
> static file independently from the dynamic file.
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a sequence
> number.
> Option 2: have the configuration version be part of the file name for dynamic
> configuration files (instead of in the file like now). Such as
> zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a
> new dynamic file (with new version) and update the link in the static file to
> point to the new dynamic one.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
