----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24208/#review49425 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/24208/#comment86491> if we no longer need the configBackwardCompatibility flag, lets remove it from everywhere. src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/24208/#comment86488> use getDynamicConfigFilename() src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/24208/#comment86492> I think instead of needEraseClientInfoFromStaticConfig you shold just have "getAllMembers().get(getId()).clientAddr != null" here. See comments below first. src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment86493> does this need to be public ? src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment86494> add a key="version", value= version number extracted from the dymicConfigFileStr into dynamicCfg - see my comment on the jira. src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment86489> indentation src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment86490> I just noticed that this would delete the dynamic stuff from the static file (server weight, etc) before the dynamic file actually exists. I missed this bug in 1992. Here's my suggestion - remove this line here. I think that when you invoke editStaticConfig after you invoke writeDynamicConfig in QuorumPeer it should just remove the clientPort stuff, because at that time the dynamic file already exists. The flag should be a bit different though - I'll comment there. - Alexander Shraer On Aug. 2, 2014, 6:06 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24208/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 6:06 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-1994 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > c4397a1 > > Diff: https://reviews.apache.org/r/24208/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
