> On Aug. 2, 2014, 6:59 p.m., Alexander Shraer wrote:
> > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java,
> > line 59
> > <https://reviews.apache.org/r/24208/diff/1/?file=649202#file649202line59>
> >
> > does this need to be public ?
It was used in QuorumPeer.java
{code}
public String getNextDynamicConfigFilename() {
return configFilename + QuorumPeerConfig.nextDynamicConfigFileSuffix;
}
{code}
> On Aug. 2, 2014, 6:59 p.m., Alexander Shraer wrote:
> > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 1356
> > <https://reviews.apache.org/r/24208/diff/1/?file=649201#file649201line1356>
> >
> > I think instead of needEraseClientInfoFromStaticConfig you shold just
> > have "getAllMembers().get(getId()).clientAddr != null" here. See comments
> > below first.
>
> Alexander Shraer wrote:
> sorry probably getAllMembers().get(getId()) != null &&
> getAllMembers().get(getId()).clientAddr != null.
> Does this make sense ?
Made sense to me.
I think instead of removing the function we can just change the function.
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24208/#review49425
-----------------------------------------------------------
On Aug. 2, 2014, 6:06 p.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24208/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2014, 6:06 p.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> ZOOKEEPER-1994
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
> c4397a1
>
> Diff: https://reviews.apache.org/r/24208/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
