[
https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094751#comment-14094751
]
Hongchao Deng commented on ZOOKEEPER-1994:
------------------------------------------
[~shralex]
This patch is ready now.
I played with it a bit and it worked great.
Workflow is like:
After startup,
{code}
dynamicConfigFile=./zoo.cfg.dynamic.1000
...
zoo.cfg.dynamic.1000:
server.1=xxx
server.2=xxx
{code}
Reconfig to add server 3, it creates a new file "zoo.cfg.dynamic.1004"
{code}
dynamicConfigFile=./zoo.cfg.dynamic.1004
...
zoo.cfg.dynamic.1004:
server.1=xxx
server.2=xxx
server.3=xxx
{code}
The hex-numeric version at the end of file matters.
Let's get this patch in.
Any feedback/requirement/comment is welcome:
https://reviews.apache.org/r/24208/
> Backup config files.
> --------------------
>
> Key: ZOOKEEPER-1994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1994-v2.patch, ZOOKEEPER-1994-v3.patch,
> ZOOKEEPER-1994-v4.patch, ZOOKEEPER-1994-v5.patch, ZOOKEEPER-1994-v6.patch,
> ZOOKEEPER-1994-v7.patch, ZOOKEEPER-1994.patch, draft.patch, first-try.patch,
> static-backup.patch
>
>
> We should create a backup file for a static or dynamic configuration file
> before changing the file.
> Since the static file is changed at most twice (once when removing the
> ensemble definitions, at which point a dynamic file doesn't exist yet, and
> once when removing clientPort information) its probably fine to back up the
> static file independently from the dynamic file.
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a sequence
> number.
> Option 2: have the configuration version be part of the file name for dynamic
> configuration files (instead of in the file like now). Such as
> zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a
> new dynamic file (with new version) and update the link in the static file to
> point to the new dynamic one.
> Review place:
> https://reviews.apache.org/r/24208/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
