[
https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096895#comment-14096895
]
Hudson commented on ZOOKEEPER-1994:
-----------------------------------
SUCCESS: Integrated in ZooKeeper-trunk #2406 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2406/])
ZOOKEEPER-1994. Auto-backup configuration files; config version becomes part of
filename (Hongchao Deng via shralex) (shralex:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1617886)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
> Backup config files.
> --------------------
>
> Key: ZOOKEEPER-1994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1994-v2.patch, ZOOKEEPER-1994-v3.patch,
> ZOOKEEPER-1994-v4.patch, ZOOKEEPER-1994-v5.patch, ZOOKEEPER-1994-v6.patch,
> ZOOKEEPER-1994-v7.patch, ZOOKEEPER-1994-v8.patch, ZOOKEEPER-1994-v9.patch,
> ZOOKEEPER-1994.patch, draft.patch, first-try.patch, static-backup.patch
>
>
> We should create a backup file for a static or dynamic configuration file
> before changing the file.
> Since the static file is changed at most twice (once when removing the
> ensemble definitions, at which point a dynamic file doesn't exist yet, and
> once when removing clientPort information) its probably fine to back up the
> static file independently from the dynamic file.
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a sequence
> number.
> Option 2: have the configuration version be part of the file name for dynamic
> configuration files (instead of in the file like now). Such as
> zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a
> new dynamic file (with new version) and update the link in the static file to
> point to the new dynamic one.
> Review place:
> https://reviews.apache.org/r/24208/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
