> On Aug. 13, 2014, 6:36 a.m., Alexander Shraer wrote: > > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java, > > lines 150-156 > > <https://reviews.apache.org/r/24208/diff/14/?file=658731#file658731line150> > > > > I think you should remove this - see earlier comment > > Hongchao Deng wrote: > This checks that versions of all servers are the same.
I understand, but instead you could get the expected config from one of the servers first, by using getVersionFromConfigStr, and then this instead of this code here just check that the config in the file + version in the filename matches expected config. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24208/#review50414 ----------------------------------------------------------- On Aug. 13, 2014, 5:20 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24208/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 5:20 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-1994 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > c4397a1 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 0a8a45a > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 89416ca > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java > c05aa1b > src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java > 1a090dc > src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java e9471be > > Diff: https://reviews.apache.org/r/24208/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
