> On Aug. 13, 2014, 6:36 a.m., Alexander Shraer wrote: > > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java, > > lines 184-193 > > <https://reviews.apache.org/r/24208/diff/14/?file=658731#file658731line184> > > > > like before, I suggest to change this to compare the version returned > > by testServerHasConfig to the version extracted from the same server's > > filename link
Yes. I will make sure compare the version from testServerHasConfig (quorum verifier). I would like to also include this check: 1. checks that versions of filenames are all the same. 2. second version is larger than first. - Hongchao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24208/#review50414 ----------------------------------------------------------- On Aug. 12, 2014, 6:54 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24208/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 6:54 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-1994 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > c4397a1 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 0a8a45a > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 89416ca > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java > c05aa1b > src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java > 1a090dc > src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java e9471be > > Diff: https://reviews.apache.org/r/24208/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
