[jira] [Commented] (ZOOKEEPER-2136) Sync() should get quorum acks.

[Hongchao Deng (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355942#comment-14355942
 ] 

Hongchao Deng commented on ZOOKEEPER-2136:
------------------------------------------

Hi Alex,

In Leader#tryToCommit, it uses "pendingSyncs":
{code}
        zk.commitProcessor.commit(p.request);
        if(pendingSyncs.containsKey(zxid)){
            for(LearnerSyncRequest r: pendingSyncs.remove(zxid)) {
                sendSync(r);
            }               
        } 
{code}

What is it? 

> Sync() should get quorum acks.
> ------------------------------
>
>                 Key: ZOOKEEPER-2136
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2136
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>             Fix For: 3.6.0
>
>         Attachments: ZOOKEEPER-2000.patch
>
>
> Currently if the sync packet goes to leader it doesn't get quorum acks. This 
> is a problem during reconfig and leader changes. testPortChange() flaky 
> failure is caused by such case.
> I proposed to change sync() semantics to require quorum acks in any case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)