----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77353 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java <https://reviews.apache.org/r/31963/#comment125263> Please remove this import. This is not used, right? src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java <https://reviews.apache.org/r/31963/#comment125258> Can we throw SSLContextException directly back to the user rather than cathing and doing e.printStacktrace(). This way it would get -1 in the commandline echo $? isn't it? src/java/test/org/apache/zookeeper/server/MockServerCnxn.java <https://reviews.apache.org/r/31963/#comment125259> Sorry for the late comment. Previously I didn't notice this. There is one more formatting issue and I could see similar cases few more places in te patch. Could you please correct the same. For example, @Override void close() { } @Override public void sendResponse(ReplyHeader h, Record r, String tag) throws IOException { } @Override void sendCloseSession() { } Here it requires a newline between the methods like, @Override void close() { } @Override public void sendResponse(ReplyHeader h, Record r, String tag) throws IOException { } @Override void sendCloseSession() { } src/java/test/org/apache/zookeeper/test/ClientBase.java <https://reviews.apache.org/r/31963/#comment125262> please add one empty line before this method. src/java/test/org/apache/zookeeper/test/ClientBase.java <https://reviews.apache.org/r/31963/#comment125261> Please modify the log by using {} instead of + LOG.error("server {} not up", hp, e); src/java/test/org/apache/zookeeper/test/ClientBase.java <https://reviews.apache.org/r/31963/#comment125260> please add one empty line before this method. - Rakesh R On March 18, 2015, 4:34 a.m., Ian Dimayuga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31963/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 4:34 a.m.) > > > Review request for zookeeper, fpj, Hongchao Deng, and Rakesh R. > > > Repository: zookeeper-git > > > Description > ------- > > Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ZooKeeperMain.java > 83273d3407f08a95dbd78a3e2b6a4f031bd956d7 > src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java > e41465ab93a3a59dbced8294e83b1651ad0dfe69 > src/java/main/org/apache/zookeeper/common/X509Util.java PRE-CREATION > src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > e02753f4fb926a8cc6c7a7c10af42f949c1e210c > src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java > b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > 09a794844978456fc3580adc22b6064e2a12cf77 > src/java/main/org/apache/zookeeper/server/ServerCnxn.java > a47d85662970cc0c219a46b226737a8689f8fe96 > src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java > 14037722c569d560acef56de0b5a7ae13464128c > src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java > 406015f84a51e6afcfe704b881f8494bdd687a25 > > src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java > PRE-CREATION > src/java/test/data/ssl/testUntrustedKeyStore.jks PRE-CREATION > src/java/test/org/apache/zookeeper/server/MockServerCnxn.java PRE-CREATION > src/java/test/org/apache/zookeeper/test/ClientBase.java > 8915dfc81d286d5114d47f5781c62b29231f7774 > src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java > 49d90f76e07e088009d30ceff3ad1597d19c31d4 > src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java > 281b1786954993618ba7085897b742349acdd7c0 > src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION > src/java/test/org/apache/zookeeper/test/X509AuthTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/31963/diff/ > > > Testing > ------- > > > Thanks, > > Ian Dimayuga > >
