> On March 22, 2015, 6:14 p.m., Rakesh R wrote: > > src/java/test/org/apache/zookeeper/test/ClientBase.java, line 251 > > <https://reviews.apache.org/r/31963/diff/2/?file=898722#file898722line251> > > > > Please modify the log by using {} instead of + > > > > LOG.error("server {} not up", hp, e);
I don't think there is an overload that supports logging an exception and interpolating format parameters. http://www.slf4j.org/api/org/slf4j/Logger.html#error%28java.lang.String,%20java.lang.Throwable%29 - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77353 ----------------------------------------------------------- On March 23, 2015, 10:29 p.m., Ian Dimayuga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31963/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 10:29 p.m.) > > > Review request for zookeeper, fpj, Hongchao Deng, and Rakesh R. > > > Repository: zookeeper-git > > > Description > ------- > > Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ZooKeeperMain.java > 83273d3407f08a95dbd78a3e2b6a4f031bd956d7 > src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java > e41465ab93a3a59dbced8294e83b1651ad0dfe69 > src/java/main/org/apache/zookeeper/common/X509Util.java PRE-CREATION > src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > e02753f4fb926a8cc6c7a7c10af42f949c1e210c > src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java > b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > 09a794844978456fc3580adc22b6064e2a12cf77 > src/java/main/org/apache/zookeeper/server/ServerCnxn.java > a47d85662970cc0c219a46b226737a8689f8fe96 > src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java > 14037722c569d560acef56de0b5a7ae13464128c > src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java > 406015f84a51e6afcfe704b881f8494bdd687a25 > > src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java > PRE-CREATION > src/java/test/data/ssl/testUntrustedKeyStore.jks PRE-CREATION > src/java/test/org/apache/zookeeper/server/MockServerCnxn.java PRE-CREATION > src/java/test/org/apache/zookeeper/test/ClientBase.java > 8915dfc81d286d5114d47f5781c62b29231f7774 > src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java > 49d90f76e07e088009d30ceff3ad1597d19c31d4 > src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java > 281b1786954993618ba7085897b742349acdd7c0 > src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION > src/java/test/org/apache/zookeeper/test/X509AuthTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/31963/diff/ > > > Testing > ------- > > > Thanks, > > Ian Dimayuga > >
