[
https://issues.apache.org/jira/browse/ZOOKEEPER-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496151#comment-14496151
]
Camille Fournier commented on ZOOKEEPER-2156:
---------------------------------------------
I think this patch is fine but isn't the problem that we had an error that we
didn't detect and reported success in starting the server, not that we didn't
check JAVA_HOME etc properly? I am not a bash shell script expert but seems
like we also need to fix this so that it doesn't claim to have started the
process when in fact it couldn't start it due to some failure.
> If JAVA_HOME is not set zk startup and fetching status command execution
> result misleads user.
> ----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2156
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2156
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: J.Andreina
> Assignee: J.Andreina
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2156.1.patch, ZOOKEEPER-2156.2.patch,
> ZOOKEEPER-2156.3.patch, ZOOKEEPER-2156.4.patch
>
>
> If JAVA_HOME is not set, zk startup and fetching status command execution
> result misleads user.
> 1. Eventhough zk startup has failed since JAVA_HOME is not set , on CLI it
> displays that zk STARTED.
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh start
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Starting zookeeper ... STARTED
> {noformat}
> 2. Fetching zk status when JAVA_HOME is not set displays that process not
> running .
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh status
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Error contacting service. It is probably not running.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
