[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497783#comment-14497783
 ] 

J.Andreina commented on ZOOKEEPER-2156:
---------------------------------------

Thanks [~fournc] for your comments.

bq.we had an error that we didn't detect and reported success in starting the 
server

I agree with you . I came across a scenario where if myid file does not exist , 
zk startup will return success eventhough startup has failed. I think we can 
handle startup failure and return proper error message in a seperate jira. 
(Provide your feedback. If it sounds good ill raise a jira)

In this jira , like description says if JAVA is not set in either JAVA_HOME or 
PATH , then zk operations will fail with error message.
Have verified the same with the patch , for different combinations of setting 
java in JAVA_HOME and PATH. 



> If JAVA_HOME is not set zk startup and fetching status command execution 
> result misleads user.
> ----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2156
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2156
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2156.1.patch, ZOOKEEPER-2156.2.patch, 
> ZOOKEEPER-2156.3.patch, ZOOKEEPER-2156.4.patch
>
>
> If JAVA_HOME is not set,  zk startup and fetching status command execution 
> result misleads user.
> 1. Eventhough zk startup has failed since JAVA_HOME is not set , on CLI it 
> displays that zk STARTED.
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh start
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Starting zookeeper ... STARTED
> {noformat}
> 2.  Fetching zk status when JAVA_HOME is not set displays that process not 
> running .
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh status
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Error contacting service. It is probably not running.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to