[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated ZOOKEEPER-2174:
-------------------------------------
Attachment: ZOOKEEPER-2174.001.patch
The attached patch checks the annotation for an expected exception before
logging the failure message. To test this change, I ran
{{ByteBufferInputStreamTest}}, which has a test case with an expected
exception. Without the patch, it logs the failure message and stack trace,
even though the test really passed. With the patch, the failure message goes
away. I also wrote an intentionally broken test (not included in this patch)
that throws an exception. When I have the expected exception annotation on
that test, it doesn't log, but once I remove the expected exception annotation,
it does log the failure message and full stack trace.
> JUnit4ZKTestRunner logs test failure for all exceptions even if the test
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Attachments: ZOOKEEPER-2174.001.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
> exception is thrown, it logs a message stating that the test failed.
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
> indicate that an exception is the expected result, and thus the test passes.
> The runner should be aware of expected exceptions and only log if an
> unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
