[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated ZOOKEEPER-2174:
-------------------------------------
Attachment: ZOOKEEPER-2174.002.patch
[~hdeng], thank you for the code review! I'm attaching patch v002 to address
your feedback. Here is sample output from {{ByteBufferInputStreamTest}}:
{code}
[junit] 2015-04-22 11:28:09,598 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD
testReadArrayOffsetLength_LengthTooLarge
[junit] 2015-04-22 11:28:09,598 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@71] - TEST METHOD
testReadArrayOffsetLength_LengthTooLarge THREW EXPECTED EXCEPTION class
java.lang.IndexOutOfBoundsException
[junit] 2015-04-22 11:28:09,598 [myid:] - INFO [main:ZKTestCase$1@65] -
SUCCEEDED testReadArrayOffsetLength_LengthTooLarge
[junit] 2015-04-22 11:28:09,598 [myid:] - INFO [main:ZKTestCase$1@60] -
FINISHED testReadArrayOffsetLength_LengthTooLarge
{code}
> JUnit4ZKTestRunner logs test failure for all exceptions even if the test
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
> exception is thrown, it logs a message stating that the test failed.
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
> indicate that an exception is the expected result, and thus the test passes.
> The runner should be aware of expected exceptions and only log if an
> unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
