[
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545345#comment-14545345
]
Hudson commented on ZOOKEEPER-2126:
-----------------------------------
FAILURE: Integrated in ZooKeeper-trunk #2692 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2692/])
ZOOKEEPER-2126 Improve exit log messsage of EventThread and SendThread by
adding SessionId (surendra singh lilhore via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1679489)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> Improve exit log messsage of EventThread and SendThread by adding SessionId
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2126
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.6.0
> Reporter: zhihai xu
> Assignee: surendra singh lilhore
> Fix For: 3.4.7, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2126.patch, ZOOKEEPER-2126_1.patch,
> ZOOKEEPER-2126_2.patch
>
>
> We saw the following out of order log when close Zookeeper client session.
> {code}
> 2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session:
> 0x24b8df4044005d4 closed
> .....................................
> 2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread
> shut down
> {code}
> This logs are very confusing if a new Zookeeper client session is created
> between these two logs. We may think new Zookeeper client session shutdown it
> EventThread instead of the old closed Zookeeper client session.
> Should we wait for sendThread and eventThread died in the ClientCnxn.close?
> We can add the following code in ClientCnxn.close.
> {code}
> sendThread.join(timeout);
> eventThread.join(timeout);
> {code}
> with the change, we won't interleave old closed session with new session.
> We can also create a new close API to support this so we won't affect the old
> code if people use old close API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
