[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated ZOOKEEPER-2191:
-------------------------------------
    Attachment: ZOOKEEPER-2191.002.patch

Liu and Rakesh, thank you for your reviews.

bq. Any document or readme needs to be updated about the Ant version as this is 
related to building the project ?

I had a similar thought before filing the patch, but I couldn't find any 
mention of Ant requirements in the current docs.  Since it wasn't already 
documented, I don't know what the minimum required version really is.  However, 
I think we can document a recommendation to use Ant 1.9.4 or later so that most 
people get the test speed-up benefit.  Here is patch v002 adding a line in 
README_packaging.txt.  Does this look good?

Thanks again!

> Continue supporting prior Ant versions that don't implement the threads 
> attribute for the JUnit task.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2191
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2191
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: ZOOKEEPER-2191.001.patch, ZOOKEEPER-2191.002.patch
>
>
> ZOOKEEPER-2183 introduced usage of the threads attribute on the <junit> task 
> call in build.xml to speed up test execution.  This attribute is only 
> available since Ant 1.9.4.  However, we can continue to support older Ant 
> versions by calling the <antversion> task and dispatching to a clone of our 
> <junit> task call that doesn't use the threads attribute.  Users of older Ant 
> versions will get the slower single-process test execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to