[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573343#comment-14573343
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2205:
---------------------------------------------------

That method seems to be a leftover from previous debugging efforts:

{code}
~/src/zookeeper-svn (master) ✔ git grep packetToString
src/java/main/org/apache/zookeeper/server/ZooTrace.java:        // + 
FollowerHandler.packetToString(qp));
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java:    static 
public String packetToString(QuorumPacket p) {
{code}

We should probably remove it. 

> Log type of unexpected quorum packet in learner handler loop
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2205
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Hitoshi Mitake
>            Assignee: Hitoshi Mitake
>            Priority: Trivial
>         Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205.patch
>
>
> Current learner handler loop doesn't log anything when it receives unexpected 
> type of quorum packet from learner.
> This patch lets the learner handler loop log the type of packet for defensive 
> purpose. It would make debugging and trouble shooting a little bit easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to