[
https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574977#comment-14574977
]
Hadoop QA commented on ZOOKEEPER-2205:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12737866/ZOOKEEPER-2205-v4.patch
against trunk revision 1683605.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//console
This message is automatically generated.
> Log type of unexpected quorum packet in learner handler loop
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2205
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.6, 3.5.0
> Reporter: Hitoshi Mitake
> Assignee: Hitoshi Mitake
> Priority: Trivial
> Fix For: 3.4.7, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch,
> ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch
>
>
> Current learner handler loop doesn't log anything when it receives unexpected
> type of quorum packet from learner.
> This patch lets the learner handler loop log the type of packet for defensive
> purpose. It would make debugging and trouble shooting a little bit easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
