[
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580103#comment-14580103
]
Rakesh R commented on ZOOKEEPER-2211:
-------------------------------------
Thank you [~wesc] for the contribution. It would be great if you can add unit
tests in {{org.apache.zookeeper.server.PurgeTxnTest}} class. Probably you can
directly call {{PurgeTxnLog#main(String [] args)}} in the tests by giving the
{{args}} array. This will help to cover the parsing logic.
+Note:+ Please don't delete the old patch which you already attached in the
jira because previous attachments would help as a reference for the reviewers.
You can attach a new patch to the jira, our jenkins will automatically picks up
the latest one and run the test.
> PurgeTxnLog does not correctly purge when snapshots and logs are at different
> locations
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
> Reporter: Wesley Chow
> Priority: Minor
> Fix For: 3.4.6, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at
> different file paths. The argument handling is buggy and only works when both
> snap and datalog dirs are given, and datalog dir contains both logs and snaps
> (snap is ignored).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
