[
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907609#comment-14907609
]
Rakesh R commented on ZOOKEEPER-2211:
-------------------------------------
Thanks [~arshad.mohammad] for taking this ahead. Patch looks overall fine, just
few comments:
# Please add one more validation to check the {{-n}} argument name. If user
pass an argument other than "-n", then should fail. Since its not using command
line parser, we could add a simple check like "-n".equals(argOption)
# instead of {{minimum value is 3}}, can you rephrase it to {{greater than 3}}.
{code}
System.out.println("\tcount -- the number of old snaps/logs you want to keep,
value should be greater than 3");
{code}
> PurgeTxnLog does not correctly purge when snapshots and logs are at different
> locations
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
> Reporter: Wesley Chow
> Assignee: Arshad Mohammad
> Priority: Minor
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at
> different file paths. The argument handling is buggy and only works when both
> snap and datalog dirs are given, and datalog dir contains both logs and snaps
> (snap is ignored).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
