[ https://issues.apache.org/jira/browse/ZOOKEEPER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704335#comment-14704335 ]
ASF GitHub Bot commented on ZOOKEEPER-2255: ------------------------------------------- GitHub user YvonneIronberg opened a pull request: https://github.com/apache/zookeeper/pull/41 ZOOKEEPER-2255 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YvonneIronberg/zookeeper zk-2255 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 ---- commit 20bf706e4d2ed01b2cf631e101ee370d2b87c3c8 Author: YvonneIronberg <yvonne.ironb...@gmail.com> Date: 2015-08-20T05:46:26Z zk-2255. ---- > Use static member classes when permitted > ---------------------------------------- > > Key: ZOOKEEPER-2255 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2255 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Yvonne Ironberg > Priority: Minor > > Using static member classes saves time and space because an instances of a > nonstatic member class has a reference to its enclosing instance. > Also did some style improvements: > - JLS recommends modifiers be in this order: public protected private > abstract static final transient volatile synchronized native strictfp. > - Inserted some spaces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)