[
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108911#comment-15108911
]
Pratima Nambiar commented on ZOOKEEPER-2139:
--------------------------------------------
With this patch, the login variable in ZookeeperSaslClient.java is no longer
statically scoped. Login is instance scoped to support different sasl
configurations. This causes a side effect in that, the thread created in
Login.java is not cleaned up when ClientCnxn is closed. We are seeing the
number of login threads increase steadily.
To resolve this, two things need to happen I think -
1. ZooKeeperSaslClient needs a close() method that will invoke login.shutdown();
2. ZooKeeperSaslClient.close() should be called in ClientCnxn.disconnect() and
in ClientCnxn.startConnect() just before the line -
zooKeeperSaslClient = new ZooKeeperSaslClient(serverPrincipal, conf);
[~arshad.mohammad] let me know what you think.
> Zookeeper client configuration should not be java system property
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.5.0
> Reporter: Surendra Singh Lilhore
> Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch,
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch,
> ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
> Configuration conf) throws IOException
> {
> ......
> ......
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
