[
https://issues.apache.org/jira/browse/ZOOKEEPER-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122158#comment-15122158
]
Hadoop QA commented on ZOOKEEPER-2358:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12784997/ZOOKEEPER-2358-3.4.patch
against trunk revision 1726354.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3017//console
This message is automatically generated.
> NettyServerCnxn leaks watches upon close
> ----------------------------------------
>
> Key: ZOOKEEPER-2358
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2358
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.7, 3.5.1
> Reporter: Ian Dimayuga
> Assignee: Ian Dimayuga
> Fix For: 3.4.8, 3.5.2
>
> Attachments: ZOOKEEPER-2358-3.4.patch, ZOOKEEPER-2358.patch
>
>
> NettyServerCnxn.close() neglects to call zkServer.removeCnxn the way
> NIOServerCnxn.close() does. Also, WatchLeakTest does not test watch leaks in
> Netty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
