[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122380#comment-15122380
 ] 

Flavio Junqueira commented on ZOOKEEPER-2358:
---------------------------------------------

Yeah, it is a bit odd to set up the cnxn factory on the setup method with 
netty, given that it is only necessary for one test case. The two options I see 
are to have the test case you're adding in a new class or not use a setUp 
method and do all that in testWatchLeakNetty. 

> NettyServerCnxn leaks watches upon close
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2358
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2358
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.7, 3.5.1
>            Reporter: Ian Dimayuga
>            Assignee: Ian Dimayuga
>             Fix For: 3.4.8, 3.5.2
>
>         Attachments: ZOOKEEPER-2358-3.4.patch, ZOOKEEPER-2358.patch
>
>
> NettyServerCnxn.close() neglects to call zkServer.removeCnxn the way 
> NIOServerCnxn.close() does. Also, WatchLeakTest does not test watch leaks in 
> Netty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to