----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119163 -----------------------------------------------------------
./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 217) <https://reviews.apache.org/r/25160/#comment180446> isnt this a read only workload (#writes = 0) ? ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 242) <https://reviews.apache.org/r/25160/#comment180447> why should it be <= numClients ? ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 267) <https://reviews.apache.org/r/25160/#comment180449> why should it be <= numClients ? ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 303) <https://reviews.apache.org/r/25160/#comment180450> why is this needed ? ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 306) <https://reviews.apache.org/r/25160/#comment180451> why is this needed ? - Alexander Shraer On Feb. 12, 2016, 7:22 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 7:22 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
