> On פבר' 13, 2016, 10:05 אחר הצהריים, Alexander Shraer wrote: > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java, > > line 224 > > <https://reviews.apache.org/r/25160/diff/16/?file=1240919#file1240919line224> > > > > isnt this a read only workload (#writes = 0) ?
Yes, but every client performs a single write (first operation). > On פבר' 13, 2016, 10:05 אחר הצהריים, Alexander Shraer wrote: > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java, > > line 249 > > <https://reviews.apache.org/r/25160/diff/16/?file=1240919#file1240919line249> > > > > why should it be <= numClients ? Should be == numClients (each client performs a single write) - Kfir ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119163 ----------------------------------------------------------- On פבר' 16, 2016, 7:04 בבוקר, Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated פבר' 16, 2016, 7:04 בבוקר) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
