[
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374048#comment-15374048
]
Alexander Shraer commented on ZOOKEEPER-2152:
---------------------------------------------
Its great that the patch solves the current problem we have. But it introduces
logic that is very specific to address this particular failing test. It may be
better
to try to generalize a bit - instead of delaying the reconnect infinitely,
perhaps we should introduce a flag like "reconnect_enabled" (true by default and
false in our test), or reconnect_disabled, which will prevent any reconnect
attempts from all the different parts of the code, which may be useful in other
tests.
What do you think ? I'm not sure how much extra work this is, so its up to you.
> Intermittent failure in TestReconfig.cc
> ---------------------------------------
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: c client
> Reporter: Michi Mutsuzaki
> Assignee: Michael Han
> Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec]
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
> Assertion: assertion failed [Expression: found != string::npos,
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
