[
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374297#comment-15374297
]
Michael Han commented on ZOOKEEPER-2152:
----------------------------------------
Thanks Alex / Raul for your feedback. Take a step back and rethink this whole
problem, I am thinking there are two issues we can address:
* These failed C reconfiguration tests was failing because the assumption these
tests were build on does not hold in first place (in this case, the tests
assumes the only clients can change the server list). So, for the purpose of
fixing these tests we can introduce some specific generalized mode that can
turn on / off certain code path (e.g. disable client retry connection logic to
make satisfy the test's prerequisites.). This is what the current patch does,
though it does not provide a generalized flag, which I agree we should fix it.
* Improve the current reconfig C tests. I think the current tests have value in
that they have good coverage on C client reconfig logic; however the foundation
/ assumption these tests build on is not very sound - the tests use fake server
so it does not simulate the real production scenario, and we don't have test
coverage for both reconfig logic + error handling when certain server failed.
So we probably should create real ZK servers and have C reconfig tests run
against those servers.
My plan is to provide a generalized solution to turn on / off C client server
connection code (for the purpose of testing pure client side logic assumes all
servers are up.). For the second issue, create a new JIRA to improve the C
reconfig tests against real servers. Does this sound a reasonable plan to you
guys?
> Intermittent failure in TestReconfig.cc
> ---------------------------------------
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: c client
> Reporter: Michi Mutsuzaki
> Assignee: Michael Han
> Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec]
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
> Assertion: assertion failed [Expression: found != string::npos,
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
