[
https://issues.apache.org/jira/browse/ZOOKEEPER-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411105#comment-15411105
]
Hadoop QA commented on ZOOKEEPER-2505:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12822401/ZOOKEEPER-2505.patch
against trunk revision 1755379.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3330//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3330//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3330//console
This message is automatically generated.
> Use shared library instead of static library in C client unit test
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2505
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
> Affects Versions: 3.5.2
> Reporter: Michael Han
> Assignee: Michael Han
> Priority: Minor
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2505.patch
>
>
> Currently we are statically linking c unit tests to ZK client library - we
> should use shared library instead as there seems no particular reason to
> stick to static library, plus one benefit of using shared library is that
> would allow us to use overrides function calls from standard libraries at
> link time so we can simulate the wrap option for ld linker on os x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
