[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411136#comment-15411136
 ] 

Michael Han commented on ZOOKEEPER-2505:
----------------------------------------

The motivation of doing it separately was to make ZOOKEEPER-1742 only includes 
changes that would impact OSX platform. Change to use shared library impact 
other platforms as well so I think maybe it is better we do it separately and 
have it run on Jenkins for a while before introducing anything in 
ZOOKEEPER-1742 so if there is a problem (which should not at least based on my 
local testing) we know who to blame :) - that said though I don't have very 
compelling reason of not including this patch as part of ZOOKEEPER-1742 so I am 
fine with either way.

> Use shared library instead of static library in C client unit test
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2505
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: c client
>    Affects Versions: 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Minor
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2505.patch
>
>
> Currently we are statically linking c unit tests to ZK client library - we 
> should use shared library instead as there seems no particular reason to 
> stick to static library, plus one benefit of using shared library is that 
> would allow us to use overrides function calls from standard libraries at 
> link time so we can simulate the wrap option for ld linker on os x. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to