Here it is, please take a look, review, and commit it to master (remember, needs to be git now :-) ) https://issues.apache.org/jira/browse/ZOOKEEPER-2576
Patrick On Mon, Sep 12, 2016 at 9:10 AM, Patrick Hunt <ph...@apache.org> wrote: > I worked up a patch last night, I'll create the jira and attach the > patch later today when I get a few. > > Patrick > > On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira <f...@apache.org> wrote: >> >>> On 12 Sep 2016, at 06:42, Patrick Hunt <ph...@apache.org> wrote: >>> >>> afaik there has never been github integration for anything with ZK. >>> QAbot only runs against jira/svn. >> >> I'm not sure what you're trying to say here. Both Apache Kafka and Apache >> BookKeeper use ZK and currently use github. >> >>> >>> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten >>> them working again. There was a ton of cruft in there which I >>> attempted to cleanup. I think things should be ok, but I will be >>> monitoring over the next few days. If you notice obvious issues please >>> lmk (vs say flakey tests). >>> >> >> Thanks for doing this, Pat. >> >>> Additionally - qabot (precommit job) is broken. The zookeeper script >>> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn >>> directly. We'll need to patch this script in order to get qabot >>> functional again - replace svn with git usage. There's only a few >>> lines but I'm not familiar with this script. If anyone wants to take a >>> stab please submit a jira/patch. I've turned off precommit job on >>> jenkins until we get this straightened out. >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/ >>> >> >> If we don't have a jira yet, we should create one. It is important to turn >> pre-commit back on. >> >> -Flavio >> >>> Patrick >>> >>> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed <br...@apache.org> wrote: >>>> sure. i'll update it to reference git rather than svn. >>>> >>>> if i understand correctly pull requests that were submitted via github were >>>> reviewed by the qa bot (or something like that) in the past, but it was >>>> turned off. we should turn that back on i think. >>>> >>>> thanx >>>> ben >>>> >>>> On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt <ph...@apache.org> wrote: >>>>> >>>>> FYI Apache INFRA has made the cutover - >>>>> https://issues.apache.org/jira/browse/INFRA-12573 >>>>> >>>>> At this point we need to update the "how to contribute" etc... Ben do >>>>> you want to take a stab at that? I can update the respective Jenkins >>>>> jobs. >>>>> >>>>> What else is there? >>>>> >>>>> Patrick >>>>> >>>>> On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth <cnaur...@hortonworks.com> >>>>> wrote: >>>>>> Thank you for doing this, Eddie. I just picked up the code review. >>>>>> >>>>>> --Chris Nauroth >>>>>> >>>>>> On 9/7/16, 9:49 AM, "Edward Ribeiro" <edward.ribe...@gmail.com> wrote: >>>>>> >>>>>> Hey folks, as part of this major change, I took a look at the >>>>>> gitignore and >>>>>> it already lacks a lot of file extensions for a modern Java project. >>>>>> Therefore, I created a trivial patch (shameless plug) that updates >>>>>> for more >>>>>> commonly extensions: >>>>>> https://issues.apache.org/jira/browse/ZOOKEEPER-2557 >>>>>> >>>>>> Could you please review it and (the committers) this incorporated >>>>>> into >>>>>> branches before the transition if everything is alright, whenever >>>>>> you have >>>>>> time? The final gitignore doesn't look particularly big and cover >>>>>> only >>>>>> mostly the common IDE extensions and temporary files. >>>>>> >>>>>> Cheers, >>>>>> Eddie >>>>>> >>>>>> >>>>>> On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira <f...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> +1 >>>>>>> >>>>>>>> On 07 Sep 2016, at 06:10, Patrick Hunt <ph...@apache.org> wrote: >>>>>>>> >>>>>>>> Quick update (more details on the INFRA jira). It might take >>>>>> upwards of >>>>>>> 24 >>>>>>>> hours to do the svn->git migration although our repo isn't that >>>>>> large, >>>>>>>> likely less. INFRA can do it, for example, on Saturday around >>>>>> 18:00 UTC. >>>>>>>> Any concerns with such an approach? >>>>>>>> >>>>>>>> Patrick >>>>>>>> >>>>>>>> On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt <ph...@apache.org> >>>>>> wrote: >>>>>>>> >>>>>>>>> Follow along here: >>>>>> https://issues.apache.org/jira/browse/INFRA-12573 >>>>>>>>> >>>>>>>>> Patrick >>>>>>>>> >>>>>>>>> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed >>>>>> <br...@apache.org> wrote: >>>>>>>>> >>>>>>>>>> with 10 votes for (5 of which are from the PMC) on no votes >>>>>> against. >>>>>>> the >>>>>>>>>> vote passes. >>>>>>>>>> >>>>>>>>>> pat please make git happen! :) >>>>>>>>>> >>>>>>>>>> thanx for voting! >>>>>>>>>> >>>>>>>>>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han >>>>>> <h...@cloudera.com> wrote: >>>>>>>>>> >>>>>>>>>>> +1 >>>>>>>>>>> >>>>>>>>>>> On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan >>>>>> <pheyyin...@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> +1 >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira >>>>>> <f...@apache.org> >>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> +1 >>>>>>>>>>>>> >>>>>>>>>>>>>> On 01 Sep 2016, at 13:28, Edward Ribeiro < >>>>>>>>>> edward.ribe...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> +1 (non binding) >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman < >>>>>>>>>>>>> jor...@jordanzimmerman.com >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> +1 (non binding) >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed >>>>>> <br...@apache.org> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> flip the switch to git and update the relevant scripts >>>>>> and docs. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> i couldn't figure out which timeframe this falls under >>>>>> in the >>>>>>>>>>> voting >>>>>>>>>>>>>>>> procedure table, but i think it's safe to go with 3 >>>>>> days, so the >>>>>>>>>>> vote >>>>>>>>>>>>>>> will >>>>>>>>>>>>>>>> close on Saturday, September 3 at 6:30pm pdt. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> +1 from me >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Cheers >>>>>>>>>>> Michael. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>> >>>> >>
